Do not append the .js extension to module names twice#39
Open
prantlf wants to merge 1 commit intomikach:masterfrom
Open
Do not append the .js extension to module names twice#39prantlf wants to merge 1 commit intomikach:masterfrom
prantlf wants to merge 1 commit intomikach:masterfrom
Conversation
…current path Paths relative to the current directory include the file extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paths relative to the current directory include the file extension. But the recognition is not easy, because the
nameparameter passed to the plugin is not the original module name from the source code. For example:RequireJS does not allow appending
.jsto module names from not relative paths. However, when writing a plugin, the./is not passed to it. As a workaround, I check if thenamedoes not end with.js. Not the ultimate fix, but works probably well enough.